Spec for MSC3077 #1602
Closed
Spec for MSC3077 #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested changes
Aug 8, 2023
| @@ -171,18 +171,34 @@ In response to an incoming invite, a client may do one of several things: | |||
|
|
|||
| ##### Streams | |||
There was a problem hiding this comment.
can we add something to https://pr1602--matrix-spec-previews.netlify.app/client-server-api/#common-fields about the new field?
Comment on lines
+191
to
+194
| Clients implementing this specification will ignore any streamless tracks. Note | ||
| that in the JavaScript WebRTC API, this means `addTrack()` must be passed two | ||
| parameters: a track and a stream, not just a track, and in a video call the | ||
| stream must be the same for both audio and video track. |
There was a problem hiding this comment.
I know this is existing text, but it now seems even more confusing than before, so I think we need to clarify.
- What is the mechanism by which streamless tracks are ignored? Or is this an instruction to clients to ignore such tracks?
- what is that to do with
addTrack's parameters? - is it related to
sdp_stream_metadata? if not, it should probably not be in the middle of the text about it?
|
closing in favour of #1735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs matrix-org/matrix-spec-proposals#3077
Preview: https://pr1602--matrix-spec-previews.netlify.app